[webkit-reviews] review requested: [Bug 78720] [Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES : [Attachment 133473] Patch

[bugzilla-daemon at webkit.org]

Roland Takacs <rtakacs at inf.u-szeged.hu> has asked  for review:
Bug 78720: [Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=78720

Attachment 133473: Patch
https://bugs.webkit.org/attachment.cgi?id=133473&action=review

------- Additional Comments from Roland Takacs <rtakacs at inf.u-szeged.hu>
>From now, GraphicsContext3DOpenGLES.cpp will be used on OpenGL ES supported
platform.
Functions are removed from GraphicsContext3DQt that already implemented in
GraphicsContext3DCommon.

"EXT" has been deleted from function and macro names ending with "EXT".
It was needed because OpenGLES does not support these (and functions and macros
without "EXT" do the same things as the
ones ending with "EXT").

Extensions3DQt is removed beceause it has never been used.

The "m_depthStencilBuffer" member is added to Qt port because it uses
"m_depthStencilBuffer" like the other platforms.

Furthermore some syntax errors have been fixed.

Unfortunately I could not test perfectly because the webgl does not work.
I get Segmentation Fault when I try to open a webgl example within
QtTestbrowser. (On desktop)
I don't get segfault on my N9 but my device draws nothing, and says that this
browser does not support webgl.