[webkit-reviews] review granted: [Bug 82045] The JSC code generator can't handle boolean arguments for Callbacks : [Attachment 133463] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 82045: The JSC code generator can't handle boolean arguments for Callbacks
https://bugs.webkit.org/show_bug.cgi?id=82045

Attachment 133463: Patch
https://bugs.webkit.org/attachment.cgi?id=133463&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review


>>> Source/WebCore/bindings/scripts/test/TestCallback.idl:42
>>> +	   boolean callbackWithBoolean(in boolean boolParam);
>> 
>> Sorry for my wrong comment in IRC. This does not test your change, since
TestObj does not have the [Callback] IDL attribute. You need to add this test
case to TestCallback.idl.
> 
> This IS in TestCallback.idl...

Sorry for the repeated confusion:)