[webkit-reviews] review granted: [Bug 81933] [Qt][WK2] default families are not set in QWebPreferences : [Attachment 133288] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 04:27:03 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 81933: [Qt][WK2] default families are not set in QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=81933

Attachment 133288: Patch
https://bugs.webkit.org/attachment.cgi?id=133288&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133288&action=review


> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:101
> +void QWebPreferencesPrivate::initFontDefaults()

WebKit usually usees initialize and not init

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:124
> +    setFontFamily(FixedFont, defaultFont.defaultFamily());
> +
> +}

unneeded newline!


More information about the webkit-reviews mailing list