[webkit-reviews] review granted: [Bug 82027] Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 3) : [Attachment 133437] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 00:15:20 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 82027: Move Notifications APIs from DOMWindow.idl to
DOMWindowNotifications.idl (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=82027

Attachment 133437: Patch
https://bugs.webkit.org/attachment.cgi?id=133437&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133437&action=review


> Source/WebCore/notifications/DOMWindowNotifications.cpp:75
> +    DOMWindowProperty::reconnectFrame(frame);
> +    m_notificationCenter = m_suspendedNotificationCenter.release();

Nit: Shall we exchange the two statements, for consistency?
DOMWindowNotification operations, and then DOMWindowProperty:: operations.


More information about the webkit-reviews mailing list