[webkit-reviews] review granted: [Bug 82002] ExecutableAllocator::memoryPressureMultiplier() might can return NaN : [Attachment 133418] Fixed mac build failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 19:54:36 PDT 2012


Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 82002: ExecutableAllocator::memoryPressureMultiplier() might can return NaN
https://bugs.webkit.org/show_bug.cgi?id=82002

Attachment 133418: Fixed mac build failure
https://bugs.webkit.org/attachment.cgi?id=133418&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133418&action=review


R=me, but fix the style goof (if it's a real one and not some bugzilla fail).

> Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:133
> +	   result = static_cast<double>(statistics.bytesReserved) /
> +	   divisor;

Is this meant to be on two lines?


More information about the webkit-reviews mailing list