[webkit-reviews] review granted: [Bug 81887] [BlackBerry] add interface clearCredentials() and clearNeverRememberSites() : [Attachment 133239] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 81887: [BlackBerry] add interface clearCredentials() and
clearNeverRememberSites()
https://bugs.webkit.org/show_bug.cgi?id=81887

Attachment 133239: Patch
https://bugs.webkit.org/attachment.cgi?id=133239&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133239&action=review


Looks good.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:418
> +    HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM
never_remember"),

never_remember sounds like it can be improved upon, maybe an english native
speaker has a suggestion, will ask in the office.