[webkit-reviews] review granted: [Bug 81983] Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page : [Attachment 133376] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 81983: Move garden-o-matic progress feedback from non-modal dialogs to a
status console anchored to the bottom of the page
https://bugs.webkit.org/show_bug.cgi?id=81983

Attachment 133376: Patch
https://bugs.webkit.org/attachment.cgi?id=133376&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133376&action=review


I assume this look pretty.  :)

> Tools/ChangeLog:10
> +	   The dialogs get in the way if you are doing multiple rebaselines.
Also,
> +	   a number of people didn't realize that you could do multiple
rebaselines
> +	   in parallel. A non-modal dialog is just confusing.

I didn't realize you could do multiple rebaselines in parallel!

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/base.js:118
> +    // FIXME: Why don't we use Object.values(dictionary)?

Because I'm dumb and I didn't know that existed.