[webkit-reviews] review denied: [Bug 81940] [chromium] Allow the viewport meta tag to be disabled for testing purposes : [Attachment 133313] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 22 15:27:00 PDT 2012
Adam Barth <abarth at webkit.org> has denied Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 81940: [chromium] Allow the viewport meta tag to be disabled for testing
purposes
https://bugs.webkit.org/show_bug.cgi?id=81940
Attachment 133313: Patch
https://bugs.webkit.org/attachment.cgi?id=133313&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133313&action=review
> Source/WebKit/chromium/public/WebView.h:263
> + // Viewport
-------------------------------------------------------------
> +
> + // If the viewport is enabled, then the viewport meta tag will allow
> + // a page to specify its own layout details
> +
> + virtual bool isViewportEnabled() const = 0;
> + virtual void enableViewport(bool enable) = 0;
Should this be part of WebPreferences? That's where we end to put enable
flags.
More information about the webkit-reviews
mailing list