[webkit-reviews] review denied: [Bug 81968] [chromium] Force update of nonFastScrollableRegion if target CCLayerImpl has been freshly created. : [Attachment 133347] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 81968: [chromium] Force update of nonFastScrollableRegion if target
CCLayerImpl has been freshly created.
https://bugs.webkit.org/show_bug.cgi?id=81968

Attachment 133347: Patch
https://bugs.webkit.org/attachment.cgi?id=133347&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133347&action=review


Good catch!  This looks like the right fix, but it definitely needs test
coverage before R+.

Dropping CCLayerImpl's on !visible is troublesome, we should perhaps revisit
that sometimes.

> Source/WebCore/ChangeLog:8
> +	   No new tests, yet. (OOPS!)

This needs tests, obviously.

> Source/WebCore/platform/graphics/chromium/TreeSynchronizer.cpp:76
> +	   // FIXME: Is it valid to assume a reused CCLayerImpl will have the
correct nonFastScrollableRegion?

yes, it is

> Source/WebCore/platform/graphics/chromium/TreeSynchronizer.cpp:77
> +	   layer->setNonFastScrollableRegionChanged(); // We just cleared the
impl layer, so don't opt-out of transferring the nonFastScrollableRegion.

the double negative isn't hard to misunderstand here. rephrase perhaps?