[webkit-reviews] review granted: [Bug 81944] [BlackBerry] Add pattern matching for hexadecimal type input fields : [Attachment 133311] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 12:13:34 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Mike Fenton <mifenton at rim.com>'s
request for review:
Bug 81944: [BlackBerry] Add pattern matching for hexadecimal type input fields
https://bugs.webkit.org/show_bug.cgi?id=81944

Attachment 133311: Patch
https://bugs.webkit.org/attachment.cgi?id=133311&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133311&action=review


Looks good, with one cleanup possibility.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:388
> +bool elementPatternIndicatesHexadecimal(const WebCore::HTMLInputElement*
inputElement)

No need for WebCore:: prefix.


More information about the webkit-reviews mailing list