[webkit-reviews] review granted: [Bug 81932] Web Inspector: text gutter decorations should move upon edits. : [Attachment 133285] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 12:09:30 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 81932: Web Inspector: text gutter decorations should move upon edits.
https://bugs.webkit.org/show_bug.cgi?id=81932

Attachment 133285: Patch
https://bugs.webkit.org/attachment.cgi?id=133285&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133285&action=review


> Source/WebCore/inspector/front-end/TextViewer.js:688
> +		   if (isNaN(lineNumber))

It's not an array.

> Source/WebCore/inspector/front-end/TextViewer.js:701
> +		       // Do not move decorations after the end position.

Do not restore


More information about the webkit-reviews mailing list