[webkit-reviews] review granted: [Bug 81929] [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes : [Attachment 133283] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Mike Fenton <mifenton at rim.com>'s
request for review:
Bug 81929: [BlackBerry] DOMSupport isPositionInNode should have early returns
for null nodes
https://bugs.webkit.org/show_bug.cgi?id=81929

Attachment 133283: Patch
https://bugs.webkit.org/attachment.cgi?id=133283&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133283&action=review


Looks good.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:299
>      int offset = 0;

I would personally move this just before it is used, but no big deal.