[webkit-reviews] review granted: [Bug 81907] [chromium] Plug-in failing to load shouldn't say "Missing Plug-in" : [Attachment 133255] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Bernhard Bauer
<bauerb at chromium.org>'s request for review:
Bug 81907: [chromium] Plug-in failing to load shouldn't say "Missing Plug-in"
https://bugs.webkit.org/show_bug.cgi?id=81907

Attachment 133255: Patch
https://bugs.webkit.org/attachment.cgi?id=133255&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133255&action=review


> Source/WebKit/chromium/public/platform/WebLocalizedString.h:78
> +	   MissingPluginText,

Should we sort this list?

> Source/WebKit/chromium/src/LocalizedStrings.cpp:213
> +    String text = query(WebLocalizedString::MissingPluginText);
> +    if (!text.isEmpty())
> +	   return text;
>      notImplemented();
>      return String("Missing Plug-in");

Do you plan to remove this fallback once Chromium is updated?  Should we remove
the notImplemented() call now that it's implemented?