[webkit-reviews] review granted: [Bug 81910] [Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject : [Attachment 133274] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Alexander Færøy
<ahf at 0x90.dk>'s request for review:
Bug 81910: [Qt][WK2] Pass Origin information to the
DatabaseQuotaDialogContextObject
https://bugs.webkit.org/show_bug.cgi?id=81910

Attachment 133274: Patch
https://bugs.webkit.org/attachment.cgi?id=133274&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133274&action=review


> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:213
> +	   WKRetainPtr<WKStringRef> scheme =
adoptWK(WKSecurityOriginCopyProtocol(securityOrigin));
> +	   WKRetainPtr<WKStringRef> host =
adoptWK(WKSecurityOriginCopyHost(securityOrigin));
> +
> +	   m_securityOrigin.setScheme(WKStringCopyQString(scheme.get()));
> +	   m_securityOrigin.setHost(WKStringCopyQString(host.get()));
> +	  
m_securityOrigin.setPort(static_cast<int>(WKSecurityOriginGetPort(securityOrigi
n)));

Would be nice to have a constructor for this in the future.