[webkit-reviews] review granted: [Bug 81804] Web Inspector: HeapProfiler: Heap snapshot worker has to report the errors to the front-end : [Attachment 133252] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 81804: Web Inspector: HeapProfiler: Heap snapshot worker has to report the
errors to the front-end
https://bugs.webkit.org/show_bug.cgi?id=81804

Attachment 133252: Patch
https://bugs.webkit.org/attachment.cgi?id=133252&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133252&action=review


> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:193
> +		   WebInspector.log(WebInspector.UIString("An error happend
when a call for method '%s' was requested", event.data.errorMethodName));

happend -> happened

> Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js:87
> +		   response.errorMethodName = data.methodName;

I think method name can be derived from the callId on the requester's side.