[webkit-reviews] review granted: [Bug 46743] Event dispatching in XMLHttpRequestProgressEventThrottle should go through XMLHttpRequestProgressEventThrottle::dispatchEvent : [Attachment 133091] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 46743: Event dispatching in XMLHttpRequestProgressEventThrottle should go
through XMLHttpRequestProgressEventThrottle::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=46743

Attachment 133091: Patch
https://bugs.webkit.org/attachment.cgi?id=133091&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133091&action=review


> Source/WebCore/ChangeLog:8
> +

Please add some details about your change and most importantly *why* you are
doing it (as a stepping stone to implement event queuing in
XMLHttpRequestProgressEventThrottle). The original ChangeLog had a very nice
description:

In preparation for platform-specific queuing of XMLHttpRequest events,
this patch changes all calls to m_target->dispatchEvent to
XMLHttpRequestProgressEventThrottle::dispatchEvent. Currently,
we queue up only a progress event on suspend() if we have throttled
progress events. We should be able to queue all XHR events that
can be generated after suspend(), if the platform network layer continues
to receive data. XMLHttpRequest uses XMLHttpRequestProgressEventThrottle
to dispatch only download events, so this doesn't change behavior of upload
events, which aren't throttled or queued.