[webkit-reviews] review granted: [Bug 81665] [GTK] icon database requests not dispatched until new data arrives : [Attachment 133226] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 81665: [GTK] icon database requests not dispatched until new data arrives
https://bugs.webkit.org/show_bug.cgi?id=81665

Attachment 133226: Patch
https://bugs.webkit.org/attachment.cgi?id=133226&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133226&action=review


Okay. Please add this commit id to the 1.8 wiki page. One comment could be
slightly cleaned up, I think.

> Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp:543
> +    // By asking for the icon directly:
> +    // 1- if we don't get the icon data now, we'll get notified about it
later (even if the initial import is not finished yet).
> +    // 2- if we get the icon data now, then success.

Perhaps you could make this slightly more concise:

We ask for the icon directly. If we don't get the icon data now, we'll be
notified later (even if the database is still importing icons).