[webkit-reviews] review granted: [Bug 81587] Increase code sharing between CSSParser and CSSPropertyLonghand. : [Attachment 133243] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 81587: Increase code sharing between CSSParser and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=81587

Attachment 133243: Patch
https://bugs.webkit.org/attachment.cgi?id=133243&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=133243&action=review


r=me

> Source/WebCore/css/CSSPropertyLonghand.cpp:31
> +CSSPropertyLonghand& backgroundLonghand()
> +{

These should be 

const CSSPropertyLonghand&

> Source/WebCore/css/CSSPropertyLonghand.cpp:59
> +CSSPropertyLonghand& backgroundRepeatLonghand()
> +{
> +    static const int backgroundRepeatProperties[] = {
CSSPropertyBackgroundRepeatX, CSSPropertyBackgroundRepeatY };
> +    DEFINE_STATIC_LOCAL(CSSPropertyLonghand, backgroundRepeatLonghand,
(backgroundRepeatProperties, WTF_ARRAY_LENGTH(backgroundRepeatProperties)));
> +    return backgroundRepeatLonghand;
> +}

These should be 

const CSSPropertyLonghand&