[webkit-reviews] review granted: [Bug 81733] Make Length Calculation functions non-inline : [Attachment 133040] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 81733: Make Length Calculation functions non-inline
https://bugs.webkit.org/show_bug.cgi?id=81733

Attachment 133040: Patch
https://bugs.webkit.org/attachment.cgi?id=133040&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=133040&action=review


r=me, we can always roll out if the perf bots hate it. I think it should be ok
though, these functions are pretty big for inlining.

> Source/WebCore/ChangeLog:3
> +	   Make Length Calculation functions regular.

Please make the title match the bug.

> Source/WebCore/ChangeLog:6
> +	   Making the Length calculation functions regular and moving them to
LengthFunctions.cpp file.

Some motivation and perf testing information here would be good.