[webkit-reviews] review granted: [Bug 81893] Remove custom bindings form ScriptProfileNode.idl of attribute type Array. : [Attachment 133230] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 05:28:58 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 81893: Remove custom bindings form ScriptProfileNode.idl of attribute type
Array.
https://bugs.webkit.org/show_bug.cgi?id=81893

Attachment 133230: Patch
https://bugs.webkit.org/attachment.cgi?id=133230&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133230&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests.

Would you please write a test that _can_ be affected by this change, if the
change were wrong? Something like "Test: xxx.html (No change in the test
result)".

> Source/WebCore/ChangeLog:10
> +	   replace [CustomGetter] Array with sequence<ScriptProfileNode>.

Normally, we write such explanations between the "Reviewed by" line and the
"Test:" line.


More information about the webkit-reviews mailing list