[webkit-reviews] review granted: [Bug 81887] [BlackBerry] add interface clearCredentials() and clearNeverRememberSites() : [Attachment 133213] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 22 04:25:08 PDT 2012
Rob Buis <rwlbuis at gmail.com> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 81887: [BlackBerry] add interface clearCredentials() and
clearNeverRememberSites()
https://bugs.webkit.org/show_bug.cgi?id=81887
Attachment 133213: Patch
https://bugs.webkit.org/attachment.cgi?id=133213&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133213&action=review
Looks good, but please fix typos and then let Charles or Leo cq+ or land for
you.
> Source/WebCore/ChangeLog:8
> + Fixed SQL issue when clear table logins and table never_remember.
when clearing
> Source/WebKit/blackberry/ChangeLog:12
> + Also implemented the corresponding funcions in class
functions.
> Source/WebKit/blackberry/ChangeLog:14
> + to perform the actuall clear table work.
actual
More information about the webkit-reviews
mailing list