[webkit-reviews] review granted: [Bug 81323] [Mac][Chromium] Should not spellcheck text pasted to an element having spellcheck disabled : [Attachment 133006] A quick fix v2 (applied comments, used the Internals interface, and skipped a new test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 23:12:01 PDT 2012


Hajime Morrita <morrita at google.com> has granted Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 81323: [Mac][Chromium] Should not spellcheck text pasted to an element
having spellcheck disabled
https://bugs.webkit.org/show_bug.cgi?id=81323

Attachment 133006: A quick fix v2 (applied comments, used the Internals
interface, and skipped a new test)
https://bugs.webkit.org/attachment.cgi?id=133006&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133006&action=review


Looks good. Thanks for the fix!

> LayoutTests/editing/spelling/spellcheck-paste-disabled.html:34
> +if (window.layoutTestController) {

You don't need this change since you the preparation phase already uses
window.internals anyway, which is only available in DRT.


More information about the webkit-reviews mailing list