[webkit-reviews] review denied: [Bug 81849] WebHistory is busted after changing time zone : [Attachment 133154] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 81849: WebHistory is busted after changing time zone
https://bugs.webkit.org/show_bug.cgi?id=81849

Attachment 133154: Patch
https://bugs.webkit.org/attachment.cgi?id=133154&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133154&action=review


At least one of these methods get called on every navigation, and probably
multiple ones.	I really hate to see the unconditionally added work at the
start of rebuildHistoryByDayIfNeeded.

You might be surprised at how heavy handed [NSTimeZone defaultTimeZone] and
[NSTimeZone isEqualToTimeZone:] might be.

I would really like us to think harder about how to do this smarter.

> Source/WebKit/mac/History/WebHistory.mm:55
> +static NSTimeZone *_timeZoneOfDayBoundaries = nil;

Why NSTimeZone when the pattern in this file was already to use CFTimeZone?