[webkit-reviews] review granted: [Bug 81850] MathML internals - improve naming in RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp : [Attachment 133155] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 17:51:18 PDT 2012


Eric Seidel <eric at webkit.org> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 81850: MathML internals - improve naming in RenderMathMLSquareRoot.cpp and
RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=81850

Attachment 133155: Patch
https://bugs.webkit.org/attachment.cgi?id=133155&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133155&action=review


LGTM.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:82
> +	   baseWrapper->style()->setPaddingLeft(Length(5 * gFrontWidthEms,
Percent));

Thank you for documenting the type of the unit in name of the variable, very
helpful!


More information about the webkit-reviews mailing list