[webkit-reviews] review denied: [Bug 80005] Implement strict testing criterion for callback function definition : [Attachment 132979] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Jeremy Mao
<yujie.mao at intel.com>'s request for review:
Bug 80005: Implement strict testing criterion for callback function definition
https://bugs.webkit.org/show_bug.cgi?id=80005

Attachment 132979: Patch
https://bugs.webkit.org/attachment.cgi?id=132979&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I'm afraid I don't think the JSC changes here are correct.  We use a couple of
different classes in JSC to represent functions with different characteristics,
JSFunction and InternalFunction.  Your isFunction check is only testing for
JSFunctions, and not InternalFunctions.  Please see comment #46 for a check
that should work.