[webkit-reviews] review granted: [Bug 81408] visual word movement: using cache to decrease the number of collectLeafBoxesInLogicalOrder on RootInlineBox : [Attachment 133120] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 81408: visual word movement: using cache to decrease the number of
collectLeafBoxesInLogicalOrder on RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=81408

Attachment 133120: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=133120&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133120&action=review


>> Source/WebCore/editing/visible_units.cpp:407
>> +		iter = wordBreakIteratorForMinOffsetBoundary(visiblePosition,
textBox, previousBoxLength, previousBoxInDifferentBlock, string, leafBoxes);
> 
> After sync, this function's parameter becomes a bit lengthy. Do you think it
is better to inline those 2 functions (wordBreakIteratorForMinOffsetBoundary
and wordBreakIteratorForMaxOffsetBoundary) or worth to introduce a struct to
hold those parameters? Neither of them sounds elegant for me.

We can do that in a follow up patch :)