[webkit-reviews] review granted: [Bug 81603] webkitpy: clean up actually getting crash logs from DRT/WTR crashes : [Attachment 132736] tweak changelog slightly

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 81603: webkitpy: clean up actually getting crash logs from DRT/WTR crashes
https://bugs.webkit.org/show_bug.cgi?id=81603

Attachment 132736: tweak changelog slightly
https://bugs.webkit.org/attachment.cgi?id=132736&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132736&action=review


Ok.  I kind of like aroben's idea of waiting until the end.  I'm not sure
whether that's going to make things go significantly faster in practice, but it
might be a good refinement to experiment with.

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:611
>	   return DriverOutput(text, output_image, actual_checksum,
audio=audio_bytes,
> -	       crash=crash, crashed_process_name=crashed_process_name,
test_time=run_time, timeout=timeout, error=error)
> +	       crash=crash, crashed_process_name=crashed_process_name,
crashed_pid=crashed_pid, crash_log=crash_log,
> +	       test_time=run_time, timeout=timeout, error=error)

This line of code is getting kind of out of control!

> Tools/Scripts/webkitpy/layout_tests/port/mac.py:169
> +	   CRASH_LOG_WAIT_TIMEOUT_SECS = 5 *
int(self.get_option('child_processes'))

Is there a reason CRASH_LOG_WAIT_TIMEOUT_SECS is in all caps?  Does get_option
return the actual number of child processes we're using (e.g., if we have
memory limitations)?