[webkit-reviews] review denied: [Bug 81786] Support fixed position elements in Qt WebKit2 : [Attachment 133058] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 81786: Support fixed position elements in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=81786

Attachment 133058: Patch
https://bugs.webkit.org/attachment.cgi?id=133058&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133058&action=review


>>> Source/WebCore/platform/graphics/GraphicsLayer.h:421
>>> +	 bool fixedPosition() const { return m_fixedPosition; }
>> 
>> setUseFixedPosition? setIsFixedPositioned() ?
> 
> setUseFixedPosition() sound good to me :)

GraphicsLayer should not know about any CSS concepts like fixed position. This
does not belong here.