[webkit-reviews] review requested: [Bug 81437] [chromium] Early out in a new prepareToDraw() step if checkerboarding an accelerated animation in order to skip the frame : [Attachment 133100] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 12:54:08 PDT 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 81437: [chromium] Early out in a new prepareToDraw() step if
checkerboarding an accelerated animation in order to skip the frame
https://bugs.webkit.org/show_bug.cgi?id=81437

Attachment 133100: Patch
https://bugs.webkit.org/attachment.cgi?id=133100&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Split CCLTHI::drawLayers() into:

bool prepareToDraw(FrameData&);
void drawLayers(const FrameData&);

I felt dirty sticking state on the LayerTreeHost, so I made a struct that the
proxy owns and passes in.

Proxys call both of these but assume that prepareToDraw is always true for now.
Follow up CL will fix that.

Great call on passing up "usedCheckboard" and doing the animation check in
calcRenderPasses.


More information about the webkit-reviews mailing list