[webkit-reviews] review granted: [Bug 81822] [MutationObservers] attributeFilter should be case sensitive at all times : [Attachment 133092] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 21 12:34:32 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 81822: [MutationObservers] attributeFilter should be case sensitive at all
times
https://bugs.webkit.org/show_bug.cgi?id=81822
Attachment 133092: Patch
https://bugs.webkit.org/attachment.cgi?id=133092&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133092&action=review
>> Source/WebCore/dom/MutationObserverRegistration.cpp:117
>> + return (m_attributeFilter.contains(attributeName));
>
> Nit: no need for parens here.
Yup, please fix this nit before landing it.
More information about the webkit-reviews
mailing list