[webkit-reviews] review granted: [Bug 81821] TileCache needs to know if its containing page is in a window : [Attachment 133090] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 81821: TileCache needs to know if its containing page is in a window
https://bugs.webkit.org/show_bug.cgi?id=81821

Attachment 133090: Patch
https://bugs.webkit.org/attachment.cgi?id=133090&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133090&action=review


r=me buuut..

> Source/WebCore/page/FrameView.cpp:855
> +	   tiledBacking->setIsInWindow(true);

Should be setIsInWindow(false).

> Source/WebCore/page/Page.h:423
> +	   bool m_isOnscreen;

My gut says s/m_isOnscreen/m_isOnScreen/g. But my gut has been wrong before.

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:227
> +    if (m_isInWindow == isInWindow)
> +	   return;

I assume there's more code coming to this function, otherwise this is pretty
overkill.