[webkit-reviews] review denied: [Bug 81795] Web Inspector: event listeners section is broken for about:blank page : [Attachment 133078] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 21 12:03:11 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 81795: Web Inspector: event listeners section is broken for about:blank
page
https://bugs.webkit.org/show_bug.cgi?id=81795
Attachment 133078: Patch
https://bugs.webkit.org/attachment.cgi?id=133078&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133078&action=review
> Source/WebCore/inspector/front-end/utilities.js:460
> + var match =
this.match(/^([^:]+):(?:\/\/)?([^\/:]*)(?::([\d]+))?(?:(\/[^#]*)(?:#(.*))?)?$/i
);
I would special case about:blank instead. Otherwise, non-urls can squeeze in.
More information about the webkit-reviews
mailing list