[webkit-reviews] review granted: [Bug 81722] compute the sign of flexibility for new flexbox : [Attachment 133067] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 81722: compute the sign of flexibility for new flexbox
https://bugs.webkit.org/show_bug.cgi?id=81722

Attachment 133067: Patch
https://bugs.webkit.org/attachment.cgi?id=133067&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133067&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:744
> +	   Length maxLength = isHorizontalFlow() ? child->style()->maxWidth() :
child->style()->maxHeight();
> +	   if (maxLength.isSpecified() && childMinMaxAppliedMainAxisExtent >
valueForLength(maxLength, flexboxAvailableContentExtent))
> +	       childMinMaxAppliedMainAxisExtent = valueForLength(maxLength,
flexboxAvailableContentExtent);
> +	   Length minLength = isHorizontalFlow() ? child->style()->minWidth() :
child->style()->minHeight();
> +	   if (minLength.isSpecified() && childMinMaxAppliedMainAxisExtent <
valueForLength(minLength, flexboxAvailableContentExtent))
> +	       childMinMaxAppliedMainAxisExtent = valueForLength(minLength,
flexboxAvailableContentExtent);

As discussed in person, I'm pretty sure this does the wrong thing for
percentages. I think we may want to use RenderBox::computeLogicalHeightUsing
and RenderBox::computeLogicalWidthInRegionUsing, but I'm not sure.

In either case, I'm fine with committing this now with a FIXME. Would be good
to get Hyatt's thoughts on the right way to do this.