[webkit-reviews] review denied: [Bug 78139] [chromium] Resolve GraphicsContext3D use and re-enable filters in the threaded compositor : [Attachment 133074] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 78139: [chromium] Resolve GraphicsContext3D use and re-enable filters in
the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=78139

Attachment 133074: Patch
https://bugs.webkit.org/attachment.cgi?id=133074&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Always making a second context in threaded mode is too heavy.  Filters are
(currently) quite rare and disabled by default, and contexts aren't super
cheap.

Can you make it only create a context if we've ever seen filters in the
process?  You could do this in some main thread part of the commit flow
(perhaps paint time) to make sure it always happens when add the first filter
in the process, and then keep the bit around as a static so it's automatically
captured on compositors going forward and restored after recovery.