[webkit-reviews] review granted: [Bug 81787] Web Inspector: make CSS and JavaScript files editable by default. : [Attachment 133055] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 81787: Web Inspector: make CSS and JavaScript files editable by default.
https://bugs.webkit.org/show_bug.cgi?id=81787

Attachment 133055: Patch
https://bugs.webkit.org/attachment.cgi?id=133055&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133055&action=review


> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:72
> +	   function mycallback(mimeType, content)

myCallback?

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:90
>      editContent: function(newContent, callback)

consider renaming to saveContent.

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:92
> +	   this._originalContent = newContent;

Please move to didEditContent

> Source/WebCore/inspector/front-end/SourceFrame.js:97
>	       this._wasHiddenWhileEditing = true;

Please remove these 2 lines.

> Source/WebCore/inspector/front-end/SourceFrame.js:530
>      doubleClick: function(lineNumber)

Consider removing this method.

> Source/WebCore/inspector/front-end/TextViewer.js:1016
> +	       this.revealLine(lineNumber);

revealLine() should be called in both modes.