[webkit-reviews] review requested: [Bug 74553] WebAudio: propagate a silence hint through the AudioNode graph. : [Attachment 133069] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 10:24:40 PDT 2012


Jer Noble <jer.noble at apple.com> has asked  for review:
Bug 74553: WebAudio: propagate a silence hint through the AudioNode graph.
https://bugs.webkit.org/show_bug.cgi?id=74553

Attachment 133069: Patch
https://bugs.webkit.org/attachment.cgi?id=133069&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
Changed the definition of isPlaying() to match the previous m_isPlaying
variable.  All tests now passing, save an ASSERT crash in
webaudio/convolution-mono-mono.html and a diff mismatch in
webaudio/audiobuffersource-channels.html which needs platform-specific
rebasing.


More information about the webkit-reviews mailing list