[webkit-reviews] review granted: [Bug 81200] [V8] V8GCForContextDispose should indicate whether a context is disposed for the main frame or not : [Attachment 133066] Rename constants.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ulan Degenbaev <ulan at chromium.org>'s
request for review:
Bug 81200: [V8] V8GCForContextDispose should indicate whether a context is
disposed for the main frame or not
https://bugs.webkit.org/show_bug.cgi?id=81200

Attachment 133066: Rename constants.
https://bugs.webkit.org/attachment.cgi?id=133066&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133066&action=review


> Source/WebCore/bindings/v8/V8GCForContextDispose.cpp:40
> +    : m_pseudoIdleTimer(this, &V8GCForContextDispose::pseudoIdleTimerFired),

> +	 m_contextDisposedForMainFrame(false)

The comma goes on line 40, just below the :

> Source/WebCore/bindings/v8/V8GCForContextDispose.cpp:46
> +    m_contextDisposedForMainFrame = m_contextDisposedForMainFrame ||
isMainFrame;

Sorry to nit-pick you names, but consider a name like
m_didDisposeContextForMainFrame.  This is an Objective-C style name, which we
often use in WebKit because of the strong Mac influence on the project.