[webkit-reviews] review granted: [Bug 81766] Web Inspector: get rid of isInEditMode, use isBeingEdited on particular element. : [Attachment 133026] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 81766: Web Inspector: get rid of isInEditMode, use isBeingEdited on
particular element.
https://bugs.webkit.org/show_bug.cgi?id=81766

Attachment 133026: Patch
https://bugs.webkit.org/attachment.cgi?id=133026&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133026&action=review


> Source/WebCore/ChangeLog:8
> +	   We should check even target and its ancestors for being edited, not
use some

even -> event

> Source/WebCore/inspector/front-end/UIUtils.js:192
> +    while (element && element.nodeType === Node.ELEMENT_NODE) {

Instead of element.nodeType === Node.ELEMENT_NODE you can just use
element.parentElement below.

> Source/WebCore/inspector/front-end/utilities.js:381
> +    this.stopImmediatePropagation();

It was stopPropagation, are you sure this change won't break any listener?