[webkit-reviews] review granted: [Bug 81663] [chromium] make trackpad gesture curves configurable externally : [Attachment 132896] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 81663: [chromium] make trackpad gesture curves configurable externally
https://bugs.webkit.org/show_bug.cgi?id=81663

Attachment 132896: Patch
https://bugs.webkit.org/attachment.cgi?id=132896&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132896&action=review


Seems mostly OK. Some issues to resolve before landing.

> Source/WebCore/platform/TouchFlingPlatformGestureCurve.h:43
> +    static PassOwnPtr<PlatformGestureCurve> create(const FloatPoint&
velocity, float unitTimeScaleVelocityThreshold = 1000, float
flingLaunchDuration = .25);

Why the default parameters? It appears these values are always set.

> Source/WebCore/platform/TouchFlingPlatformGestureCurve.h:49
> +    explicit TouchFlingPlatformGestureCurve(const FloatPoint& velocity,
float unitTimeScaleVelocityThreshold, float flingLaunchDuration);

no explicit for c'tors with >1 arg

> Source/WebCore/platform/TouchFlingPlatformGestureCurve.h:55
> +

extra newline