[webkit-reviews] review granted: [Bug 81200] [V8] V8GCForContextDispose should indicate whether a context is disposed for the main frame or not : [Attachment 133020] Rebase and add a check for m_frame->page()

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Ulan Degenbaev
<ulan at chromium.org>'s request for review:
Bug 81200: [V8] V8GCForContextDispose should indicate whether a context is
disposed for the main frame or not
https://bugs.webkit.org/show_bug.cgi?id=81200

Attachment 133020: Rebase and add a check for m_frame->page()
https://bugs.webkit.org/attachment.cgi?id=133020&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133020&action=review


LGTM with a style nit.

> Source/WebCore/bindings/v8/V8GCForContextDispose.cpp:72
> +    const int kLongIdlePauseInMs = 1000;
> +    const int kShortIdlePauseInMs = 10;

We don't typically prefix constants with k. So just longIdlePauseInMS and
shortIdlePauseInMs.