[webkit-reviews] review denied: [Bug 81782] Web Inspector: event listener section doesn't show all event listeners of the element ancestors : [Attachment 133039] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 81782: Web Inspector: event listener section doesn't show all event
listeners of the element ancestors
https://bugs.webkit.org/show_bug.cgi?id=81782

Attachment 133039: Patch
https://bugs.webkit.org/attachment.cgi?id=133039&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133039&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:726
> +void InspectorDOMAgent::getEventListenersForNode(ErrorString* error, int
nodeId, RefPtr<InspectorArray>& listenersArray)

Please rebaseline

> Source/WebCore/inspector/InspectorDOMAgent.cpp:732
> +	   *error = "No such node";

Please use assertNode