[webkit-reviews] review granted: [Bug 80602] Convert some fast/regions pixel tests to reftests : [Attachment 132914] updates to LayoutTests/fast/regions/positioned-objects-inline-static-spanning-regions-expected.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 07:09:46 PDT 2012


Dirk Schulze <krit at webkit.org> has granted hermwong <hermanw at adobe.com>'s
request for review:
Bug 80602: Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=80602

Attachment 132914: updates to
LayoutTests/fast/regions/positioned-objects-inline-static-spanning-regions-expe
cted.html
https://bugs.webkit.org/attachment.cgi?id=132914&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132914&action=review


LGTM. r=me

> LayoutTests/ChangeLog:12
> +	   - removed the "no red should be visible..." text from the
positioned-objects-inline-static-in-rtl-regions because there was no red in the
test file and the statement was irrelevant to the test.   
> +	   - removed text from the
positioned-objects-inline-static-spanning-regions.html test because it had
nothing to do with the test. We based this on the visuals of the test and the
fact that the test description made no mention of the text at all     

Please break lines for change logs in the future.


More information about the webkit-reviews mailing list