[webkit-reviews] review requested: [Bug 81323] [Mac][Chromium] Should not spellcheck text pasted to an element having spellcheck disabled : [Attachment 133006] A quick fix v2 (applied comments, used the Internals interface, and skipped a new test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 04:07:25 PDT 2012


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 81323: [Mac][Chromium] Should not spellcheck text pasted to an element
having spellcheck disabled
https://bugs.webkit.org/show_bug.cgi?id=81323

Attachment 133006: A quick fix v2 (applied comments, used the Internals
interface, and skipped a new test)
https://bugs.webkit.org/attachment.cgi?id=133006&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Morita-san and Niwa-san,

Thanks for your review and comments.
I have moved a isSpellCheckingEnabled() check to SpellChecker::isCheckable().
(On the other hand, a isInPasswordField() check is in Editor.cpp because this
check is not so trivial.) Also have I updated this change to use the Internals
interface and added the new test to Skipped lists. Would it be possible to take
another look?

Regards,

Hironori Bono


More information about the webkit-reviews mailing list