[webkit-reviews] review requested: [Bug 79859] Customize layout test timeout value for different ports. : [Attachment 132985] patch v3

[bugzilla-daemon at webkit.org]

Johnny(Jianning) Ding <jnd at chromium.org> has asked  for review:
Bug 79859: Customize layout test timeout value for different ports.
https://bugs.webkit.org/show_bug.cgi?id=79859

Attachment 132985: patch v3
https://bugs.webkit.org/attachment.cgi?id=132985&action=review

------- Additional Comments from Johnny(Jianning) Ding <jnd at chromium.org>
(In reply to comment #12)
> If you want, you can make sure that kill_timeout_seconds is at least 3.0
here. That would deal with the case of time_out_ms being less than
default_test_timeout_ms.
> 
> Really this chunk of code is very confusing. Seems like we should always just
set kill_timeout_seconds to 3.0.

I don't know the context of this chunk, but if time_out_ms is greater than
default_test_timeout_ms, the kill_timeout_seconds is greater than 3.0
Patch3 is  going to make sure that kill_timeout_seconds is at least 3.0.