[webkit-reviews] review denied: [Bug 13624] REGRESSION: can select text of an input button : [Attachment 132978] Updated Patch for chromium pixel test failures

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Parag Radke <parag at motorola.com>'s
request for review:
Bug 13624: REGRESSION: can select text of an input button
https://bugs.webkit.org/show_bug.cgi?id=13624

Attachment 132978: Updated Patch for chromium pixel test failures
https://bugs.webkit.org/attachment.cgi?id=132978&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132978&action=review


r- due to inefficient implementation.

> Source/WebCore/rendering/RenderButton.h:51
> +    virtual bool canBeSelectionLeaf() const { return
node()->rootEditableElement(); }

Finding rootEditableElement is very expensive. You should either call
isContentEditable() or rendererIsEditable(). Call later if the layout is
up-to-date whenever canBeSelectionLeaf is called.

> Source/WebCore/rendering/RenderTextFragment.h:42
> +    virtual bool canBeSelectionLeaf() const { return
node()->rootEditableElement(); }

Ditto.