[webkit-reviews] review denied: [Bug 81420] Break the association between form controls and their owner when the owner leaves the tree : [Attachment 132409] Added expectation

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Adam Klein <adamk at chromium.org>'s
request for review:
Bug 81420: Break the association between form controls and their owner when the
owner leaves the tree
https://bugs.webkit.org/show_bug.cgi?id=81420

Attachment 132409: Added expectation
https://bugs.webkit.org/attachment.cgi?id=132409&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132409&action=review


> Source/WebCore/html/HTMLFormElement.cpp:161
> +    for (unsigned i = 0; i < m_associatedElements.size(); ++i)
> +	   m_associatedElements[i]->formRemovedFromTree(root);

This is a bad iteration pattern.  formRemovedFromTree() updates
m_associatedElements.

Form-association code is complex, and introducing
FormAssociatedElement::m_formNeedsSameRootCheck makes it more complex.	I'd
like to avoid m_formNeedsRootCheck as possible.
I'd like to change formRemovedFromTree() so that it unregister a control only
if the control has form= attribute or its root is different from the root of
this form.