[webkit-reviews] review granted: [Bug 81702] Sandboxed PluginProcess should use private temporary and cache directories : [Attachment 132904] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 20 16:20:38 PDT 2012


Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 81702: Sandboxed PluginProcess should use private temporary and cache
directories
https://bugs.webkit.org/show_bug.cgi?id=81702

Attachment 132904: proposed patch
https://bugs.webkit.org/attachment.cgi?id=132904&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review


>
Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:105
> +    String systemDirectorySuffix = "com.apple.WebKit.PluginProcess+" +
PluginProcess::shared().pluginBundleIdentifier();

I think you should just call
PluginProcess::shared().netscapePluginModule()->module()->bundleIdentifier();
directly here.


More information about the webkit-reviews mailing list