[webkit-reviews] review canceled: [Bug 81600] webkitpy: get ServerProcess out of the reportcrash business : [Attachment 132911] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 20 15:39:47 PDT 2012
Dirk Pranke <dpranke at chromium.org> has canceled Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 81600: webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600
Attachment 132911: Patch
https://bugs.webkit.org/attachment.cgi?id=132911&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
The actual fix:
layout_tests $ git diff port/webkit.py
494c494,497
< return self._server_process.has_crashed()
---
> if self._server_process.has_crashed():
> self._crashed_subprocess_name = self._port.driver_name()
> return True
> return False
501c504,505
< elif error_line == "#CRASHED - WebProcess\n":
---
> return True
> if error_line == "#CRASHED - WebProcess\n":
503a508
> return True
More information about the webkit-reviews
mailing list