[webkit-reviews] review granted: [Bug 79704] Restrict access to notifications for unique origins and file URLs with no local file access : [Attachment 132860] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 79704: Restrict access to notifications for unique origins and file URLs
with no local file access
https://bugs.webkit.org/show_bug.cgi?id=79704

Attachment 132860: Patch
https://bugs.webkit.org/attachment.cgi?id=132860&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132860&action=review


> Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp:99
> -    HashMap<String, bool>::const_iterator it =
m_permissionsMap.find(origin->toString());
> +    HashMap<String, bool>::const_iterator it =
m_permissionsMap.find(origin->toRawString());

Should we ASSERT that the origin isn't unique here?  This code seems like it
would do the wrong thing for unique origins, but based on the other changes in
the patch, I don't think that can happen.