[webkit-reviews] review granted: [Bug 81678] Make distributeExtraLogicalHeightToRows return the consumed logical height : [Attachment 132847] Proposed fix 1.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 81678: Make distributeExtraLogicalHeightToRows return the consumed logical
height
https://bugs.webkit.org/show_bug.cgi?id=81678

Attachment 132847: Proposed fix 1.
https://bugs.webkit.org/attachment.cgi?id=132847&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132847&action=review


> Source/WebCore/rendering/RenderTableSection.cpp:427
> -int RenderTableSection::distributeExtraLogicalHeightToPercentRows(int
extraLogicalHeight, int totalPercent)
> +void RenderTableSection::distributeExtraLogicalHeightToPercentRows(int&
extraLogicalHeight, int totalPercent)

Nit: Maybe we should reverse the parameter order. I think in/out params
normally come last.

> Source/WebCore/rendering/RenderTableSection.cpp:454
> -int RenderTableSection::distributeExtraLogicalHeightToAutoRows(int
extraLogicalHeight, unsigned autoRowsCount)
> +void RenderTableSection::distributeExtraLogicalHeightToAutoRows(int&
extraLogicalHeight, unsigned autoRowsCount)

Ditto.